Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1deg_jra55do_ryf: Revert #94 (use DT_THERM=6*DT and DIABATIC_FIRST = False) #104

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

dougiesquire
Copy link
Collaborator

In #94, untested changes were made to MOM6 parameter DT_THERM and related parameters. This PR reverts those changes until testing has been done and a suitable value of DT_THERM has been determined.

@dougiesquire dougiesquire changed the title Revert #94 (use DT_THERM=6*DT and DIABATIC_FIRST = False) 1deg_jra55do_ryf: Revert #94 (use DT_THERM=6*DT and DIABATIC_FIRST = False) Aug 21, 2024
Copy link
Contributor

@aekiss aekiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dougiesquire

Copy link

@minghangli-uni minghangli-uni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @dougiesquire

@dougiesquire dougiesquire merged commit 51282fb into 1deg_jra55do_ryf Aug 21, 2024
@dougiesquire dougiesquire deleted the 1deg_jra55do_ryf.revert_#94 branch August 21, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants