Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/quay image tag #14

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Feature/quay image tag #14

merged 4 commits into from
Dec 7, 2023

Conversation

lbeckman314
Copy link
Contributor

@lbeckman314 lbeckman314 commented Dec 7, 2023

Changes

  • Builds are now triggered on every push (and through the 'Run Workflow' button on the Actions page)
  • Quay images are tagged by the Branch name of the pushed commit (with slashes replaced by underscores*)
Branch Quay Image Tag
main main, latest
development development
feature/elasticsearch7 feature_elasticsearch7

This follows the same convention as uc-cdis (e.g. Fence on Quay.io), with the added benefit of defaulting to the 'main' or 'latest' branch if no tag is specified.

Additional Resources


*Error when adding tag with a slash:

docker build -t quay.io/ohsu-comp-bio/pod:feature/foo .
[+] Building 0.0s (0/0)                                                                                                                                                 docker:desktop-linux
ERROR: invalid tag "quay.io/ohsu-comp-bio/aced-etl-job:feature/foo": invalid reference format

@lbeckman314 lbeckman314 added the enhancement New feature or request label Dec 7, 2023
@lbeckman314 lbeckman314 self-assigned this Dec 7, 2023
@lbeckman314 lbeckman314 merged commit 8ad3043 into development Dec 7, 2023
1 check passed
@lbeckman314 lbeckman314 deleted the feature/quay-image-tag branch December 7, 2023 22:45
@bwalsh
Copy link
Collaborator

bwalsh commented Dec 11, 2023

Tested on local development LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants