-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional class documentation #399
Additional class documentation #399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, just a few missing things and a couple misleading comments in relation to Add*Functions methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine now
I added some documentation to namespaces since they'll be necessary for entity creation. In various places I have things like (objects/simple classes/groups) written. It makes no sense to call them classes because an object is not a class. What else could I call it? |
Personally I would just refer to them as "entries", but I suppose someone else could come up with a better term. |
I just went with entries, that should work. |
Anything else you might want to add/change? It seems alright. |
I think this is ready to be merged. I don't think I'll need to add/change anything else. |
Following up from the previous documentation update, this one should document the remainder of the base class files.