Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool Documentation #408

Merged
merged 9 commits into from
Jun 20, 2024

Conversation

LengthenedGradient
Copy link
Contributor

Originally intended this to be a rework as a stepping stone for future developments.
This adds documentation to many of the tool related functions, heavily leveraging LuaLS' annotations for clarity.
Some parts were modified for added clarity.
I realize an outright rework is unnecessary.

This will improve organization
Removed GetToolInformation and made GetToolData initialize all fields of ToolData.
Will probably modify tool_functions.lua itself, accepting the misordering of stages and operations
Copy link
Member

@TwistedTail TwistedTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's just a commented out debug print that could be removed, everything else is perfectly fine.

lua/acf/menu/tool_functions.lua Outdated Show resolved Hide resolved
@TwistedTail TwistedTail merged commit 174e22d into ACF-Team:dev Jun 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants