Add support for env_logger for qemu binary only fuzzers #2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenukk
reviewed
Jan 6, 2025
| @@ -95,6 +95,7 @@ pub struct FuzzerOptions { | |||
| pub const MAX_INPUT_SIZE: usize = 1048576; // 1MB | |||
|
|
|||
| pub fn fuzz() -> Result<(), Error> { | |||
| env_logger::init(); | |||
There was a problem hiding this comment.
Why not just use the simple logger from libafl?
There was a problem hiding this comment.
for now, we are using a mix of env_logger and libafl logger.
maybe we could create some kind of StdLogger and unify logging usage?
There was a problem hiding this comment.
I mean everybody is free to use whatever they want, that's what libraries are for :D
but if you just want to see the logs and don't care about the extra stuff env logger provides there's no reason for the extra dependency
There was a problem hiding this comment.
I wanted to be able to set the log output level at runtime rather than compile time. I don't think that the simple logger supports that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log messages changed to
log::infoso they aren't compiled out of release builds. They are in non-performance critical portions of code.