Deduplicate OnDisk Corpus #2827
Draft
+75
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokatoka
reviewed
Jan 11, 2025
tokatoka
reviewed
Jan 11, 2025
| /// An input for the target | ||
| #[cfg(not(feature = "std"))] | ||
| pub trait Input: Clone + Serialize + serde::de::DeserializeOwned + Debug { | ||
| pub trait Input: Clone + Serialize + serde::de::DeserializeOwned + Debug + Hash { |
There was a problem hiding this comment.
please don't add this. We want to keep the trait bounds as minimal as possible
There was a problem hiding this comment.
The logic behind this is that people just need to implement Hash to their custom inputs now instead of generate_name(). The name of the testcase will then be the hash of the contents of the input, which is one of the things proposed in #2434
There was a problem hiding this comment.
Ok. but we just want to avoid any other traits bounds being added to this pub trait Input.
(unless it is really really really necessary)
what you can do is remove generate_name() from this trait
then make a public
pub fn generate_name<I: Hash>(input: I) -> String {
// do your stuff
}
then call it from other places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #2434
Original PR (now closed) #2802