Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change awk regex command to capture the coordinate address properly #1079

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

michelle-yooh
Copy link
Collaborator

@michelle-yooh michelle-yooh commented Dec 3, 2024

Description

While running A3+ benchmarking using XPK, I noted "Failed to recognize coordinator address" happening. Upon investigating, I noted that this regex is not capturing the address properly. An example log message looks like:

Server: 34.118.224.10 Address: 34.118.224.10#53 ...

and the "Address" part is in the middle, rather than beginning, which is captured by ^. Thus we need to remove this.

FIXES: b/381196280

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@michelle-yooh michelle-yooh force-pushed the yooh/gpu_coordinator_address branch from 12c6f50 to 6423d99 Compare December 5, 2024 07:21
@copybara-service copybara-service bot merged commit 1c09a2e into main Dec 5, 2024
14 checks passed
@copybara-service copybara-service bot deleted the yooh/gpu_coordinator_address branch December 5, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants