-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote Python Support for Benchmark Runner #1174
base: main
Are you sure you want to change the base?
Conversation
fd538eb
to
2f8124f
Compare
c9df323
to
443586b
Compare
60a5bd5
to
443586b
Compare
059e78e
to
75167f0
Compare
@@ -0,0 +1,123 @@ | |||
"""Copyright 2025 Google LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am unclear on why we added this new recipe file. Why is updating the pathways yaml if sidecar is provided sufficient? This should be agnostic to the model config used to run with remote python.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I fully understand the question. There's an equivalent XPK change (AI-Hypercomputer/xpk#326) needed for this to work end to end, and this benchmark runner uses that feature on XPK.
And yes the model config used is agnostic, since anyone can technically run remote python with the current setup. Since we're still developing, we'll likely need to make some edits to this recipe once RP is feature complete -- specifically to feature gate (e.g. using a USE_REMOTE_PYTHON option or such, similar to ENABLE_PERSISTENCE in pathwaysutils).
Remote Python Support for Benchmark Runner Add Remote Python Recipe Clean up Add Delete Capabilities Minor edits Fix Fix problems Changes Changes Fixes Undo Weird Merge Save work Break out args helper Fix file imports Move around stuff cleanup Fix Clean up comment whitespace Fix issues Fix lint
75167f0
to
6427792
Compare
Description
Adds a recipe for testing and eventually benchmarking the Pathways Remote Python feature.
This is an initial PR that will set the precedent for future recipes. It is designed to be shareable and have common functionality (like flag parsing) that can be shared across recipes, but flexible and standard so that multiple team members can simply run the file with minimal configuration changes. It's designed to avoid superfluous flag adding and continue pythonically using configs.
This recipe in particular is for testing functionality for remote python.
Tests
Tested this change on a test remote python sidecar server on a v6e and a v5e shared test cluster.
Sibling XPK change: AI-Hypercomputer/xpk#326
Checklist
Before submitting this PR, please make sure (put X in square brackets):