Add a tp -i for interactive workflows
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tengyifei
force-pushed
the
yifeit/dev-cycle
branch
3 times, most recently
from
1447c5d to
529cd25
Compare
With this change, we can run: - `tp -i test ...` to run some unit tests - `tp -i run ...` to run a distributed SPMD command And the script will monitor the filesystem for changes. It will re-trigger the command again whenever one changes a file. I also found some flags to make the CPU checks faster. Tested: `tp -i test torchprime/torch_xla_models` to repeatedly run the torch_xla model tests upon edit.
tengyifei
force-pushed
the
yifeit/dev-cycle
branch
from
529cd25 to
a482079
Compare
qihqi
approved these changes
Jan 22, 2025
|
Thanks! Looks very convenient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we can run:
tp -i test ...to run some unit teststp -i run ...to run a distributed SPMD commandAnd the script will monitor the filesystem for changes. It will re-trigger the command again whenever one changes a file, leading to an ergonomic dev/test cycle.
I also found some flags to make the CPU checks faster.
Tested:
tp -i test torchprime/torch_xla_modelsto repeatedly run the torch_xla model tests upon edit.