remove --private from cluster

Signed-off-by: Piotr Pawłowski <[email protected]>
AI-Hypercomputer · Jan 7, 2025 · 415d84d · 415d84d
1 parent 3d4a71c
commit 415d84d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/.github/workflows/build_tests.yaml b/.github/workflows/build_tests.yaml
@@ -52,7 +52,7 @@ jobs:
         echo zone=us-central2-b >> $GITHUB_OUTPUT
     - name: set tpu-type
       id: set-tpu-type
-      run: |    
+      run: |
         echo tpu-type=v4-8 >> $GITHUB_OUTPUT
     - name: set location
       id: set-location

diff --git a/.github/workflows/cluster_create.yaml b/.github/workflows/cluster_create.yaml
@@ -33,7 +33,7 @@ on:
         required: true
       location:
         type: string
-        required: true
+        required: trues
 
 env:
   # Names must be unique in parallel running tests.
@@ -71,10 +71,8 @@ jobs:
         echo $PWD/bin >> "$GITHUB_PATH"
     - name: Check xpk installation
       run: xpk --help
-    - name: Create a private Pathways-enabled XPK Cluster with 2x ${{inputs.tpu-type}} nodepools. Larger num-nodes to avoid master resizing.
-      run: python xpk.py cluster create-pathways --cluster ${{inputs.cluster-name}} --private --tpu-type=${{inputs.tpu-type}}  --num-slices=2 --zone=${{inputs.zone}} --default-pool-cpu-machine-type=n1-standard-16 --default-pool-cpu-num-nodes=16 --reservation='${{ secrets.GCP_TPU_V4_RESERVATION }}' --custom-cluster-arguments="${CLUSTER_ARGUMENTS}"
-    - name: Verify the created cluster is private
-      run: gcloud container clusters describe ${{inputs.cluster-name}} --location=${{inputs.location}} --format="value(privateClusterConfig.enablePrivateNodes)" | grep 'True' || (echo 'The created cluster is not private.' && exit 1)
+    - name: Create a Pathways-enabled XPK Cluster with 2x ${{inputs.tpu-type}} nodepools. Larger num-nodes to avoid master resizing.
+      run: python xpk.py cluster create-pathways --cluster ${{inputs.cluster-name}} --tpu-type=${{inputs.tpu-type}}  --num-slices=2 --zone=${{inputs.zone}} --default-pool-cpu-machine-type=n1-standard-16 --default-pool-cpu-num-nodes=16 --reservation='${{ secrets.GCP_TPU_V4_RESERVATION }}' --custom-cluster-arguments="${CLUSTER_ARGUMENTS}"
     - name: Authenticate Docker
       run: gcloud auth configure-docker --quiet