Skip to content

Commit

Permalink
Set min-master-version for A3-Ultra clusters (#322)
Browse files Browse the repository at this point in the history
  • Loading branch information
sharabiani authored Jan 14, 2025
1 parent 072f7de commit 839e75e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/xpk/core/blueprint/blueprint_generator.py
Original file line number Diff line number Diff line change
Expand Up @@ -482,6 +482,7 @@ def generate_a3_ultra_blueprint(
use=[net_0_id],
settings={
"release_channel": "RAPID",
"min_master_version": "1.31.4-gke.1072000",

This comment has been minimized.

Copy link
@annuay-google

annuay-google Jan 14, 2025

Please remove this as discussed- this will fail if the k8s patch or GKE patch version is no longer supported. This happens frequently

"prefix_with_deployment_name": False,
"name_suffix": cluster_name,
"system_node_pool_machine_type": system_node_pool_machine_type,
Expand Down
1 change: 1 addition & 0 deletions src/xpk/core/tests/data/a3_ultra.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ deployment_groups:
use: [gke-a3-ultra-net-0]
settings:
release_channel: "RAPID"
min_master_version: "1.31.4-gke.1072000"
prefix_with_deployment_name: false
name_suffix: gke-a3-ultra
system_node_pool_machine_type: "e2-standard-16"
Expand Down

0 comments on commit 839e75e

Please sign in to comment.