Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up JobSet failure policy on workloads #308

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Set up JobSet failure policy on workloads #308

wants to merge 1 commit into from

Conversation

IrvingMg
Copy link
Collaborator

@IrvingMg IrvingMg commented Jan 3, 2025

Fixes / Features

  • Handling exit codes on Workloads with JobSet failure policy.

Testing / Documentation

Testing details.

  • [ y/n ] Tests pass
  • [ y/n ] Appropriate changes to documentation are included in the PR

@IrvingMg IrvingMg force-pushed the feature/set-up-jobset-failure-policy branch from e5f75ed to 63738ec Compare January 3, 2025 14:00
@IrvingMg IrvingMg force-pushed the feature/set-up-jobset-failure-policy branch 3 times, most recently from d8052eb to 7299390 Compare January 7, 2025 09:45
@IrvingMg IrvingMg marked this pull request as ready for review January 7, 2025 10:16
@IrvingMg IrvingMg force-pushed the feature/set-up-jobset-failure-policy branch 2 times, most recently from f6da574 to aaf355d Compare January 13, 2025 09:24
@IrvingMg
Copy link
Collaborator Author

cc @pawloch00

@pawloch00
Copy link
Collaborator

LGTM for me

@pawloch00 pawloch00 requested a review from Obliviour January 13, 2025 10:13
pawloch00
pawloch00 previously approved these changes Jan 13, 2025
View reviewed changes
@IrvingMg IrvingMg force-pushed the feature/set-up-jobset-failure-policy branch 4 times, most recently from 29e0b85 to f61369f Compare January 15, 2025 17:28
@IrvingMg IrvingMg marked this pull request as draft January 15, 2025 17:38
@IrvingMg IrvingMg force-pushed the feature/set-up-jobset-failure-policy branch 7 times, most recently from da2859e to f0055e0 Compare January 16, 2025 12:34
@IrvingMg IrvingMg force-pushed the feature/set-up-jobset-failure-policy branch 4 times, most recently from b6d7e2c to 4d8def1 Compare January 22, 2025 08:39
@IrvingMg IrvingMg force-pushed the feature/set-up-jobset-failure-policy branch 8 times, most recently from 50f81c0 to 0bd2638 Compare January 25, 2025 17:26
@IrvingMg IrvingMg marked this pull request as ready for review January 25, 2025 17:54
@IrvingMg IrvingMg force-pushed the feature/set-up-jobset-failure-policy branch from 0bd2638 to 684e5fc Compare January 28, 2025 07:56
@IrvingMg
Copy link
Collaborator Author

cc: @Obliviour @pawloch00

@pawloch00 pawloch00 changed the base branch from main to develop January 28, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawloch00 pawloch00 pawloch00 left review comments

@44past4 44past4 Awaiting requested review from 44past4 44past4 is a code owner

@sharabiani sharabiani Awaiting requested review from sharabiani sharabiani is a code owner

@BluValor BluValor Awaiting requested review from BluValor BluValor is a code owner

@Obliviour Obliviour Awaiting requested review from Obliviour Obliviour is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IrvingMg @pawloch00 @Obliviour