Add workflow with building pip #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Pawłowski <[email protected]>
…pawl-build-wheels
Signed-off-by: Piotr Pawłowski <[email protected]>
…pawl-build-wheels
pawloch00
requested review from
Obliviour,
44past4,
sharabiani and
BluValor
as code owners
Signed-off-by: Piotr Pawłowski <[email protected]>
44past4
reviewed
Jan 27, 2025
.github/workflows/build_wheels.yaml
Outdated
| uses: pypa/gh-action-pypi-publish@release/v1 | ||
| with: | ||
| repository-url: https://test.pypi.org/legacy/ | ||
|
|
| with: | ||
| name: python-package-distributions | ||
| path: dist/ | ||
| - name: Publish distribution 📦 to TestPyPI |
There was a problem hiding this comment.
nit: Inconsistent naming of steps between publish-to-testpypi and publish-to-pypi.
.github/workflows/build_wheels.yaml
Outdated
| repository-url: https://test.pypi.org/legacy/ | ||
|
|
||
| publish-to-pypi: | ||
| name: >- |
There was a problem hiding this comment.
nit: Why we need this line break with ">-"?
44past4
previously approved these changes
Jan 27, 2025
Signed-off-by: Piotr Pawłowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Features
Testing / Documentation
Testing details.