Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SNP readers #19

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve SNP readers #19

wants to merge 3 commits into from

Conversation

salcc
Copy link
Member

@salcc salcc commented Feb 5, 2025

salcc added 3 commits February 5, 2025 12:24
@salcc
Clean pgen.py
c47f435
@salcc
Fix bed.py variant filtering and add add tests for sample and variant…
d0d61ce 
… filtering

Fixes #7
@salcc
Add parameter to specify separator in SNP readers (fixes #18) and add…
f73411f 
…s automatic separator detection

Also fixed the docstring format of internal VCFReaderPolars methods
@salcc salcc requested review from davidbonet and miriambt February 5, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbonet davidbonet Awaiting requested review from davidbonet

@miriambt miriambt Awaiting requested review from miriambt

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand to support other delimiters? bug: pgen & bed readers fail due to row_nr()
1 participant
@salcc