Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use canonical variables for the installation locations of libraries and binaries #1377

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

andriish
Copy link
Contributor

@andriish andriish commented Jan 6, 2025

Use canonical variables for the installation locations of libraries and binaries

BEGINRELEASENOTES

  • Use CMAKE_INSTALL_LIBDIR and CMAKE_INSTALL_BINDIR to install libraries and binaries

ENDRELEASENOTES

@MarkusFrankATcernch
Copy link
Contributor

Happy New Year to all!

@andresailer
Do you agree with these changes ?

Copy link

github-actions bot commented Jan 6, 2025

Test Results

  9 files    9 suites   1h 38m 15s ⏱️
367 tests 343 ✅ 0 💤 24 ❌
518 runs  459 ✅ 0 💤 59 ❌

For more details on these failures, see this check.

Results for commit 317b9ae.

♻️ This comment has been updated with latest results.

@andriish andriish marked this pull request as draft January 6, 2025 23:35
@andresailer
Copy link
Member

Do you agree with these changes ?

I won't answer until I see that all the tests are passing. But this has the potential to also break other peoples installation procedures.

@andresailer andresailer self-requested a review January 7, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants