-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add globbing support in makeReader
and CreateDataSource
#729
Open
m-fila
wants to merge
14
commits into
AIDASoft:master
Choose a base branch
from
m-fila:glob
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
reviewed
Feb 3, 2025
Just for completeness bringing the conclusions from todays meeting here:
|
This reverts commit 60c9b02.
I think that should cover now all the points from the meeting except for harmonizing the Python bindings for readers |
tmadlener
reviewed
Feb 6, 2025
tmadlener
reviewed
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
makeReader
andCreateDataSource
. Added standalone helperpodio::utilities::expand_glob
to resolve globs.get_reader
ENDRELEASENOTES
This is a proposition to make
makeReader
andCreateDataSource
overloads a taking single filename also accept and expand a POSIX glob pattern.The behaviour is:
Closes #686
podio::makeReader
podio::CreateDataFrame
- [x] Python side -podio.get_reader
podio.CreateDataFrame