Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upper bound to celery dependency #75

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Feb 22, 2024

Considering the usage of Celery in the library (only shared_task), I don't think adding an upper bound is necessary.

@sastred sastred self-assigned this Feb 26, 2024
@sastred
Copy link
Member

sastred commented Feb 26, 2024

Hi Viicos,

I agree that the usage is very small but I prefer to minimize possible breaking changes in Celery. I think we can change the dependency to 'celery>=5.0,<6'. Do you agree?

@Viicos
Copy link
Contributor Author

Viicos commented Feb 26, 2024

I agree that the usage is very small but I prefer to minimize possible breaking changes in Celery. I think we can change the dependency to 'celery>=5.0,<6'. Do you agree?

If it was me I would rather go with no upper bounds (I usually like to link this article) but I'm fine with <6!

@sastred
Copy link
Member

sastred commented Feb 26, 2024

Thanks for the link, it's very interesting and it has very good points. However, I think of Celery more as a queue framework rather than a small library. Reviewing the v4 -> v5 changelog there are a couple of sentences that suggest that it is not safe to upgrade to major versions automatically:

Starting from now users should expect more frequent releases of major versions as we move fast and break things to bring you even better experience.

Celery 5.0 introduces a new CLI implementation which isn’t completely backwards compatible.

I prefer to set a <6 dependency and check if it keeps working when 6.0 is released.

@coveralls
Copy link

Coverage Status

coverage: 76.864%. remained the same
when pulling 3e7b909 on Viicos:celery-version
into 8a356ec on APSL:master.

@sastred sastred merged commit c46e82d into APSL:master Feb 26, 2024
6 checks passed
@Viicos Viicos deleted the celery-version branch February 26, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants