Merge pull request #7 from ARCANEDEV/patch-1

Fixing the Collection whereIn Method
ARCANEDEV · Aug 9, 2016 · e02933d · e02933d
2 parents b756cfb + 18e12e2
commit e02933d
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 29 deletions.
diff --git a/src/Collection.php b/src/Collection.php
@@ -10,34 +10,14 @@
  */
 class Collection extends IlluminateCollection
 {
-    /* ------------------------------------------------------------------------------------------------
-     |  Illuminate Functions
-     | ------------------------------------------------------------------------------------------------
-     */
-    /**
-     * Filter items by the given key value pair.
-     *
-     * @param  string  $key
-     * @param  array   $values
-     * @param  bool    $strict
-     *
-     * @return static
-     */
-    public function whereIn($key, array $values, $strict = true)
-    {
-        return $this->filter(function ($item) use ($key, $values, $strict) {
-            return in_array(data_get($item, $key), $values, $strict);
-        });
-    }
-
     /* ------------------------------------------------------------------------------------------------
      |  Custom Functions
      | ------------------------------------------------------------------------------------------------
      */
     /**
      * Reset the collection.
      *
-     * @return self
+     * @return static
      */
     public function reset()
     {

diff --git a/tests/CollectionTest.php b/tests/CollectionTest.php
@@ -14,14 +14,6 @@ class CollectionTest extends TestCase
      |  Test Functions
      | ------------------------------------------------------------------------------------------------
      */
-    /** @test */
-    public function it_can_use_where_in()
-    {
-        $c = new Collection([['v' => 1], ['v' => 2], ['v' => 3], ['v' => '3'], ['v' => 4]]);
-
-        $this->assertEquals([['v' => 1], ['v' => 3]], $c->whereIn('v', [1, 3])->values()->all());
-    }
-
     /** @test */
     public function it_can_reset()
     {