Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tailor_gui): Make fan graph colors more robust #47

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

AaronErhardt
Copy link
Owner

No description provided.

@AaronErhardt AaronErhardt merged commit 11c7c2d into main Nov 28, 2023
2 checks passed
@AaronErhardt AaronErhardt deleted the fix-graph-colors branch November 28, 2023 20:20
@mrcjkb
Copy link
Contributor

mrcjkb commented Nov 28, 2023

@AaronErhardt looks like the automated release PR action failed.

I think it requires PRs to be squash-merged, so that the resulting commit message fits conventional commits.

@AaronErhardt
Copy link
Owner Author

From the release please README:

Both squash-merge and merge commits work with Release PRs.

So according to release-please, both should work. The error is quite confusing though.
Yet, I will squash the next PR to see whether that fixes the problem.

@mrcjkb
Copy link
Contributor

mrcjkb commented Nov 28, 2023

🤔 Based on this issue, maybe a retry is enough?

@AaronErhardt
Copy link
Owner Author

Nope, the workflow failed again. The action seems to fail consistently. I think it's rather related to https://github.com/google-github-actions/release-please-action/issues/795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants