Add a new md_add_new_row_to_sorted_list function to insert a row into a list column's target table in the correctly sorted position so we do not need to re-sort later. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a list column's target table in the correctly sorted position so we do not need to re-sort later. This functionality will be used in the IMetaDataEmit implementation to ensure that new Param table entries are specified in Sequence order. This is something that the runtime depends on (and DNMD already validates in the md_apply_delta function), but is not specified in ECMA-335 or in the ECMA-335 Augments doc. As a result, I don't think we need to block developers from using md_add_new_row_to_list with the ParamList column (we also use this function in the apply-delta functionality for this case). Instead, we can rely on users to use the API that provides the guarantees necessary for their use case.
AaronRobinsonMSFT
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality will be used in the IMetaDataEmit implementation to ensure that new Param table entries are specified in Sequence order.
This is something that the runtime depends on (and DNMD already validates in the md_apply_delta function), but is not specified in ECMA-335 or in the ECMA-335 Augments doc. As a result, I don't think we need to block developers from using md_add_new_row_to_list with the ParamList column (we also use this function in the apply-delta functionality for this case). Instead, we can rely on users to use the API that provides the guarantees necessary for their use case.