Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage rework #7

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Storage rework #7

merged 3 commits into from
Dec 4, 2024

Conversation

Ableytner
Copy link
Owner

This pull request includes:

  • Slightly rework the storages' logic
  • Rename Storage.contains to Storage.contains_item
  • Rename Storage.exists to Storage.contains
  • Add StorageView, which is a read-only singleton class which reads from both the PersistentStorage and VolatileStorage. This eliminates the need to remember where items such as the DiscordBot instance or storage_file are stored for read access.

@Ableytner Ableytner merged commit c254019 into main Dec 4, 2024
3 checks passed
@Ableytner Ableytner deleted the storage-rework branch December 4, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant