Feature/document loaders #19 #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Splitter struct with new, split_documents, and create_documents methods - Refactored TextSplitter trait implementation - Introduced Arc for thread-safe reference counting - Added serde_json::Value and crate::schemas::Document dependencies
- Added split_documents method to TextSplitter trait with implementation for splitting documents.
- Create new file 'recursive_character.rs' and implement RecursiveCharacter for text splitting. - Re-define data type of 'chunk_size' and 'chunk_overlap' in SplitterOptions from i32 to usize. - Modify len_func in SplitterOptions to direct function rather than option. - Update SplitterOptions with builder pattern for the updated fields. - Update TextSplitter's join_documents function to remove unnecessary else block. - Update TokenSplitter to match the data type changes in SplitterOptions. - Add or update test cases as per the changes made.
Add support for custom base_url and model for OpenAI embedding. This change allows users to specify their own base URL and model when using the OpenAiEmbedder struct. This will make it easy to get started with self-hosted RAGs. Closes #21
…r struct In this commit, the following changes were made: - Added a new field 'second_splitter' of type Option<Box<dyn TextSplitter>> to the SplitterOptions struct in options.rs. - Refactored the RecursiveCharacter struct in recursive_character.rs to RecursiveCharacterSplitter, updating the implementation and usage of the struct accordingly. These changes enhance the flexibility and functionality of the text splitting module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.