Update UI library used for Web Viewer #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same GUI lib as used for ThreeJS examples.
kwokcb
commented
Dec 19, 2023
| @@ -9,7 +9,7 @@ import { RGBELoader } from 'three/examples/jsm/loaders/RGBELoader.js'; | |||
|
|
|||
| import { prepareEnvTexture, getLightRotation, findLights, registerLights, getUniformValues } from './helper.js' | |||
| import { Group } from 'three'; | |||
| import { GUI } from 'dat.gui'; | |||
There was a problem hiding this comment.
This is the library which is an add-on to Three.js but can directly be pulled in.
| @@ -445,13 +445,10 @@ export class Editor | |||
| // | |||
| clearFolders() | |||
| { | |||
| Array.from(document.getElementsByClassName('folder')).forEach( | |||
| Array.from(document.getElementsByClassName('lil-gui')).forEach( | |||
There was a problem hiding this comment.
The DOM element to clear is different for lil-gui than dat.gui.
jstone-lucasfilm
approved these changes
Dec 19, 2023
jstone-lucasfilm
merged commit cbff01a
into
AcademySoftwareFoundation:main
30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
lil-guiwhich fixes a number of dat-gui issues including all input which did not show up anymore (regresssion).Examples