ofxImageEffect.h - Desired Premult #62
Conversation
This Property defines an host level policy. So effects receiving an ImageOpaque and Generator know to be Premult or Straight if they don't generate a full Alpha.
Added clarification of interaction between kOfxImageEffectPropPreMultiplication clip preference and state of a particular instance regarding kOfxImageEffectHostDesiredPremult
include/ofxImageEffect.h
Outdated
|
|
||
| - Type - string X 1 | ||
| - Property Set - a plugin instance (read only) | ||
| - Default - 0 | ||
| - Property Set - a plugin instance (read only). Ideally this information should already be available at parameter creation stage. |
There was a problem hiding this comment.
I don't think we should add comments like "Ideally". Just "should" or "must". Who would be helped by this change?
include/ofxImageEffect.h
Outdated
| Valid Values - This must be one of | ||
|
|
||
| - kOfxImagePreMultiplied - the image is premultiplied by its alpha | ||
| - kOfxImageUnPreMultiplied - the image is unpremultiplied | ||
|
|
||
| This Property defines an host level policy. | ||
| This Property defines an host level policy. It is for practical purposes considered global in the scope of a Project. |
There was a problem hiding this comment.
When you say "It is for practical purposes considered global" are you really saying that a host should (or must) not change its value? If so, do you mean it must be constant per plugin instance, constant for all instances of a given plugin, or what? And why? Why couldn't a host pass different values to different instances?
include/ofxImageEffect.h
Outdated
| This Property defines an host level policy. | ||
| This Property defines an host level policy. It is for practical purposes considered global in the scope of a Project. | ||
|
|
||
| Recommended Interpretation: If an host adds support for OfxImageEffectHostDesiredPremult, the host should set on the output the same value on output clip kOfxImageEffectPropPreMultiplication preference |
There was a problem hiding this comment.
This needs some grammar work.
There was a problem hiding this comment.
:) - upping the standard now
Also should not say Recommended but Expected here I guess
Fixes comments
|
This is now implemented, using |
This Property defines an host level policy. So effects receiving an ImageOpaque and Generator know to be Premult or Straight if they don't generate a full Alpha. See Standard Change issue #66.