FindFFMPEG: Support linking against static FFMPEG libraries on Linux #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Rusch <[email protected]>
nrusch
force-pushed
the
ffmpeg_linux_static_link
branch
from
b43080d to
500e7ce
Compare
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
FindFFMPEGmodule to facilitate linking against static FFMPEG libraries on Linux.The changes do the following (currently only for static FFMPEG libraries):
-Wl,-Bsymbolicflag to each imported target'sINTERFACE_LINK_OPTIONS.pkg-configto look up the transitive dependencies of each imported target, and including them in the target'sINTERFACE_LINK_LIBRARIES, as well as populatingINTERFACE_LINK_DIRECTORIES.The second step could potentially be done for both static and dynamic FFMPEG libraries, but I kept the scope of this narrow to start with.
Fixes #60.