Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New theme and home page layout #203

Closed
wants to merge 22 commits into from
Closed

Conversation

andrewstiefel
Copy link
Contributor

This first pull request includes an updated theme for the website (header, footer, branding) and a new home page layout.

@uncheckederror and @danry25: I'm working on a Mac and don't have a local test environment. I've tried to make this first pull request a non-breaking change as much as possible, but please let me know if you encounter any unexpected issues.

Reworked design theme and _layout.cshtml to include new header and footer.
@danry25 danry25 requested a review from uncheckederror July 8, 2021 17:38
@danry25 danry25 added the external Helps an external customer label Jul 8, 2021
@uncheckederror
Copy link
Collaborator

uncheckederror commented Jul 10, 2021

Here's the setup instructions for running the project on Mac: https://dotnet.microsoft.com/learn/dotnet/hello-world-tutorial/install (Select the macOS tab)

Once you have the runtime installed then you can open a command prompt in the NumberSearch.Mvc folder and execute the command "dotnet run". Then open a web browser and got to the localhost URL listed in the command prompt. (Probably https://localhost:5001) You might get a warning, because there's no SSL certificate installed, ignore that.

It should look like this when it works.
image

The homepage will work, because it's composed only of static content. The other pages may break though, as you're missing the API keys and database credentials and what not.

You may need to restart the app from the command prompt after you make changes, so that you'll be able to see them in your browser.

@uncheckederror uncheckederror added the enhancement New feature or request label Jul 10, 2021
@andrewstiefel
Copy link
Contributor Author

I installed the .NET SDK, but when I try to run the application, I get an error for an unrecognized Guid format [Line 49 in NumberSearch.Mvc/WorkerServices/MonitorLoop.cs]. Do I need to follow the process to configure user secrets?

Screen Shot 2021-07-11 at 4 54 30 PM

@uncheckederror
Copy link
Collaborator

No that error is unrelated. I haven't seen that guid parsing error before. The app will start up and display the homepage without any of the keys which would normally be provided by the user-secrets process. If you're feeling up to it you can comment out the failing line. It's interesting that I haven't seen this on Linux or windows yet 🤔

@uncheckederror
Copy link
Collaborator

@andrewstiefel I've changed the way GUID are parsed from the config file. This should prevent you from getting the same error when you try to run the Mvc app.

@andrewstiefel
Copy link
Contributor Author

@uncheckederror Thank you! It's working now. I fixed some errors on the home page, but I noticed the new theme is causing issues on the other pages. I'm going to work on pulling those design changes into this request.

I am receiving two errors in the application. One on hardware (see screenshot) and the number search page is blank. Is that a result of working in the test environment without keys? Or is there another conflict?

Screen Shot 2021-07-20 at 7 55 29 PM

@uncheckederror
Copy link
Collaborator

uncheckederror commented Jul 22, 2021

Yes, that's happening because the app can't access the database. I'm glad it's working for you now.

@andrewstiefel andrewstiefel marked this pull request as ready for review July 27, 2021 04:58
@danry25
Copy link
Collaborator

danry25 commented Oct 8, 2021

I see the recent layout changes to the Features Page and the Contact Page modifications. I don't think we will be adding a Contact Page at this time, and we need @Chattaeus to resolve issue #155 so we can wrap up the Features Page.

Closing this issue & PR as the verbiage, header and footer and design elements have been uplifted into the main repository.

@danry25 danry25 closed this Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request external Helps an external customer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature a clear value proposition on the home page Implement branding and new base layout
4 participants