#1839: limit noRootFolder validation rule to types other than cloudpa…

…ges, lists, automations, attributeSets
Accenture · Nov 7, 2024 · fbb2afd · fbb2afd
1 parent bf124ba
commit fbb2afd
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 7 deletions.
diff --git a/@types/lib/metadataTypes/Automation.d.ts b/@types/lib/metadataTypes/Automation.d.ts
diff --git a/@types/lib/metadataTypes/Automation.d.ts.map b/@types/lib/metadataTypes/Automation.d.ts.map
diff --git a/@types/lib/metadataTypes/definitions/Automation.definition.d.ts b/@types/lib/metadataTypes/definitions/Automation.definition.d.ts
diff --git a/@types/lib/util/validations.d.ts.map b/@types/lib/util/validations.d.ts.map
diff --git a/lib/util/validations.js b/lib/util/validations.js
@@ -28,7 +28,13 @@ export default async function validation(definition, item, targetDir, codeExtrac
     try {
         if (customRuleImport) {
             customRules = customRuleImport
-                ? await customRuleImport.validation(definition, item, targetDir, Util)
+                ? await customRuleImport.validation(
+                      definition,
+                      item,
+                      targetDir,
+                      Util,
+                      codeExtractItemArr
+                  )
                 : {};
         }
     } catch (ex) {
@@ -67,6 +73,14 @@ export default async function validation(definition, item, targetDir, codeExtrac
                     // some types do not support folders
                     return true;
                 }
+                const doNotEvaluate = ['automation', 'attributeSet', 'list'];
+                if (
+                    doNotEvaluate.includes(definition.type) ||
+                    (definition.type === 'asset' && item?.assetType?.name === 'webpage')
+                ) {
+                    // this subtype is not visible in the interface and hence always technically sits in the root
+                    return true;
+                }
 
                 return folderPath.includes('/');
             },