Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task/2005 resolve locationTypeId on fileLocation #2006

Merged
merged 2 commits into from
Jan 21, 2025
Merged

task/2005 resolve locationTypeId on fileLocation #2006

merged 2 commits into from
Jan 21, 2025

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Jan 21, 2025 •
edited
Loading

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added the c/fileLocation COMPONENT label Jan 21, 2025
@JoernBerkefeld JoernBerkefeld self-assigned this Jan 21, 2025
@JoernBerkefeld JoernBerkefeld linked an issue Jan 21, 2025 that may be closed by this pull request
[TASK] Resolve locationTypeId on fileLocation #2005
Closed
@github-actions github-actions bot added the chore Jira issue-type "Task" label Jan 21, 2025
@github-actions GitHub Actions
Copy link

Coverage Report

Commit:1989c34
Base: develop@70dd9e9

Type Base This PR
Total Statements Coverage  70.54%  70.54%  (+0%)
Total Branches Coverage  69.33%  69.33%  (+0%)
Total Functions Coverage  83.3%  83.21%  (-0.09%)
Total Lines Coverage  70.54%  70.54%  (+0%)
Details (changed files):
File Statements Branches Functions Lines
lib/metadataTypes/FileLocation.js  88.88%  83.33%  75%  88.88%

@JoernBerkefeld JoernBerkefeld merged commit 0062a70 into develop Jan 21, 2025
9 checks passed
@JoernBerkefeld JoernBerkefeld deleted the task/2005-resolve-locationtypeid-on-filelocation branch January 21, 2025 16:03
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
c/fileLocation COMPONENT chore Jira issue-type "Task"
Projects
None yet
Milestone
7.6.3
Development

Successfully merging this pull request may close these issues.

[TASK] Resolve locationTypeId on fileLocation
1 participant
@JoernBerkefeld