Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Victoria Sawchuk -- Carets #25

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

Victoria Sawchuk -- Carets #25

wants to merge 38 commits into from

Conversation

vsawchuk
Copy link

@vsawchuk vsawchuk commented Dec 4, 2017

BackTREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What role does the Model play in Backbone? The model is responsible for abstraction of business logic for single instances.
How did the presence of Models and Collections change the way you thought about your app? I became more focused on the interactions, purposes, and organization of events and functions in how they related to models and collections. I took advantage of some built-in Backbone collection features for API consumption.
How do Backbone Events compare to DOM events? Backbone events are concerned with data, whereas DOM events are concerned with the elements shown in a browser.
How did you approach filtering? What was your data flow for this feature? I used two collections, one that is the entire collection of trips from the API, and one that contains the trips I would like to display. When the user selects a filter category, I update this variable, and I only use it when they type in filter text. I used a JS Array.prototype.filter function to get the resulting collection that I display.
What do you think of Backbone in comparison to raw JavaScript & jQuery? I still need to become more familiar with Backbone, but it seems very helpful for logic abstraction and API communication.
Do you have any recommendations on how we could improve this project for the next cohort? This week felt pretty stressful, given the combination fo interview prep and homework. I'm not sure if it's possible or a good idea to ease up on the requirements for this project in the future since it's important for all of us to have a basic understanding of Backbone (and we have limited time), but that might be something to consider.

…rip page if successful, show errors and do not clear form if unsuccessful
@CheezItMan
Copy link

BackTREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good number of commits and good commit messages
Comprehension questions Check, you can also use the Collection's filter function to filter the collection.
Organization
Models and collections are defined in separate files
Code that relies on the DOM is located in or called by $(document).ready
Code follows the Backbone data flow (DOM event -> update model or collection -> Backbone event -> update DOM)
Functionality
Display list of trips Check
Display trip details Check
Register for a trip Check, good work putting some validations in, I would suggest making sure that there is an @ in the email field.
Add a trip Well done!
Sort trips Check
General
Snappy visual feedback for user actions screens change rapidly and smoothly, no spiffy animation, but that wasn't required.
API error handling Yep!
Client-side validation Check
Bonus Filtering Filtering by weeks isn't working, Good work getting what you did finished however.
Overall Really nice work! You hit all the requirement. You did a really good job of breaking tasks down into small individual methods.

const loadFormFields = function loadFormFields(formId, formFieldsArray) {
clearContent();
formFieldsArray.forEach((item) => {
$(`#${formId}`).append(formTemplate({field: item}));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very clever method to generate the form you need. The downside is that you can't create controls like select which keep a user from entering an invalid choice. Similarly you can't have inputs of type number.

How could you adapt this method to improve the UX?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants