-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laura Robertson -- Carets #33
base: master
Are you sure you want to change the base?
Conversation
BackTREKWhat We're Looking For
|
}); | ||
|
||
// ------------- Reserve a Trip -------------- | ||
$('body').on('submit', '.book-trip', function form(e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
validations??
<form class='add-trip-form'> | ||
<h4>Add a trip</h4> | ||
<input type='text' name='name' placeholder='Name' /> | ||
<input type='text' name='continent' placeholder='Continent' /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A select
element would make a better choice, not giving the user an option for an invalid continent.
<h4>Add a trip</h4> | ||
<input type='text' name='name' placeholder='Name' /> | ||
<input type='text' name='continent' placeholder='Continent' /> | ||
<input type='text' name='about' placeholder='About' /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A textarea would make a better choice.
}); | ||
|
||
$(document).on('click', function() { | ||
const modal = document.getElementById('add-trip'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid mixing JavaScript and jQuery selections, use one or the other, in this case I'd suggest jQuery.
BackTREK
Congratulations! You're submitting your assignment!
Comprehension Questions