-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipes - Sairagul - BackTrek #45
base: master
Are you sure you want to change the base?
Conversation
BackTREKWhat We're Looking For
|
|
||
const Reservation = Backbone.Model.extend({ | ||
|
||
url: function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be better as a urlRoot
function.
generatedHTML.on('click',(event) => { | ||
$('#trips').hide(); | ||
$('#trip').show(); | ||
trip.fetch({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding an error
event handler to deal with times that the API doesn't work and let the user know.
tripList.fetch({ | ||
success(model, response) { | ||
render(model); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding an error
event handler to deal with times that the API doesn't work and let the user know.
BackTREK
Congratulations! You're submitting your assignment!
Comprehension Questions