Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipes - Kimberley Zell - Static Site #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kimpossible1
Copy link

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Not sure.
Why is it important to consider and use semantic HTML? So the html is well organized and makes it more efficient to add styling with CSS.
How did you decide to structure your CSS? I started with the Index page and styled it and then moved from there to each individual page, reusing what code I could and making classes and IDs for sections that would be different.
What was the most challenging piece of this assignment? Getting CSS to do what I wanted it to do, and also having so little time for a project that requires some creativity and design.
Describe one area that you gained more clarity on when completing this assignment How to access elements.

@droberts-sea
Copy link

Static Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage no - even for HTML / CSS, it's important to use git to keep a record of what changed and why
Answered comprehension questions yes - regarding question 2, semantic HTML is not only useful as a tool for developers, it also enables assistive technologies like screen readers
Page fully loads yes
No broken links (regular or images) no - see inline comment
Includes at least 4 pages and styling yes
HTML
Uses the high-level tags for organization: header, footer, main yes
Appropriately using semantic tags: section, article, etc. yes
All images include alternate text no - alt text is important for if the image fails to load, and for accessibility tools
CSS
Using class and ID names in style declarations yes
Style declarations are DRY yes
Overall Site is attractive and easy to navigate - good work!


<img src="/Users/kzell/Documents/Ada/Static-Site/images/Indo-water-backbend.jpg">

<img src="/Users/kzell/Documents/Ada/Static-Site/images/Thailand-lizard-balance.jpg">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all absolute paths - they go all the way from the root of your filesystem (the directory /) to where the file lives. While this works on your computer, it does not work on mine, since I don't have a directory /Users/kzell. Instead you should use relative paths, like ../images/Thailand-island-view.jpg.

A quick search-and-replace of /Users/kzell/Documents/Ada/Static-Site/ -> ../ seems to fix the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants