Tanja and Kimberley -- ^Carets^

[misstonbon]

Video Store API

Congratulations! You're submitting your assignment!
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.

Comprehension Questions

Question	Answer
Explain how you came up with the design of your ERD, based on the seed data.	We didn't start with creating an ERD, we focused on rendering the correct JSON based on initial requirements. We added relationships when we got to the optionals section. Rentals belong to both customer and movie.
Describe a set of positive and negative test cases you implemented for a model.	We tested for the possibility of rental when there are no movies in available_inventory and rental return when there are no movies rented out in customers rental history
Describe a set of positive and negative test cases you implemented for a controller.	We tested controller ability to render a valid JSON with all the appropriate HTML status codes, as well as its failure cases.
How does your API respond when bad data is sent to it?	:bad_request
Describe one of your custom model methods and why you chose to wrap that functionality into a method.	One of custom model methods is set_default_available_inventory where if the movie is newly created, its available_inventory for rental purposes will simply be whatever the starting inventory is.
Do you have any recommendations on how we could improve this project for the next cohort?	Make instructions around smoke tests clearer. Example: Look at smoke tests, write code according to smoke tests. We wrote code according to instructions which weren't coinciding with how smoke tests were written and then it was too late to adjust considering our workload this week unrelated to VideoStore. Confusing instructions in ReadMe, otherwise, this assignment provided more exposure to Postman and we've taken a liking to it.
Link to Trello	We didn't use Trello. Sorry.
Link to ERD	ERD is auto-created by the erd gem and available in the Root file for your perusal.

[tildeee]

Video Store

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	x
Comprehension questions	x
General
Business Logic in Models	x
All 3 required endpoints return expected JSON data	x
Requests respond with appropriate HTTP Status Code	x
Errors are reported	x
Testing
Passes all Smoke Tests	x * see my note at the bottom about this
Model Tests - all relations, validations, and custom functions test positive & negative cases	x
Controller Tests - URI parameters and data in the request body have positive & negative cases	x
Optionals	Still a few failing smoke tests on optionals on my end
POST routes use URI parameter and request body to add a new record to the database	x
GET /customers shows how many movies are checked out by a customer	x
GET /movies/:title shows updated inventory	x
Overall

Y'all forked from AdaGold instead of from Ada-C8's copy of VideoStoreAPI. On the Ada-C8 version of it, there were updates to the project, particularly in the smoke tests we provided. I'm doing my best to grade as is, but be mindful to fork from Ada-C8 next time.