Marisa Morris - Carets #23

marisamorris · 2017-09-11T06:30:04Z

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision?	Whether or not to initialize the rooms automatically or use a helper method due to not every hotel having twenty rooms. I chose to use a method to create the rooms because I figured if this project is ever built on, it should be able to be changed easily.
Describe a concept that you gained more clarity on as you worked on this assignment.	Using inheritance as well as how to use the built in Date object.
Describe a nominal test that you wrote for this assignment.	Being able to instantiate each class.
Describe an edge case test that you wrote for this assignment.	An edge case would be if the check in date is in the past or the check out date is before the check in date for the create reservation method
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	Writing pseudo code then the tests were much more helpful in that it helped me figure out what i ultimately wanted each class and method to do in addition to where i needed to refactor my Hotel class.

…nd Room classes.

…to initialize method.

…umber instance

…hat wasnt needed).

…est passing

…mplete.

…lass. block rate method tests passing

CheezItMan · 2017-09-14T19:41:53Z

Hotel

What We're Looking For

Feature	Feedback
Baseline
Used git regularly	Decent number of commits, good messages
Answer comprehension questions	Check
Design
Each class is responsible for a single piece of the program	Most of the program is in the `Hotel` class. You need to break out the functionality more.
Classes are loosely coupled	Everything in this program revolves around the `Hotel` class, The other classes don't have much functionality.
Wave 1
List rooms
Reserve a room for a given date range	Check via the `rooms_not_reserved` method
List reservations for a given date	Check via `reservations_by_date`.
Calculate reservation price	Your reservation class has the method, see my notes about it.
Invalid date range produces an error	Check
Wave 2
View available rooms for a given date range	Check
Reserving a room that is not available produces an error	Nope: `create_reservation` doesn't check to ensure the room hasn't already been reserved!
Wave 3
Create a block of rooms	There' not check here for dates that are invalid.
Check if a block has rooms	There's a way to reserve a room from a block, but no way to see if a block has rooms.
Reserve a room from a block	Via the `reserve_room_in_block` method. There are no tests for the dates. See my notes on these classes.
Test coverage	99% !
Additional Feedback	You are putting almost all your business logic into `Hotel` and not the other classes. Those other classes seem mostly to be used to store data. This makes it a very difficult design to change, modify or reuse components. For things like `Reservation` you test the data types of attributes and instantiating, but no tests for edge cases. This is problematic. I'd like you to go over your design with your tutor and your tests as well and talk about what you could do differently and how to write tests for a class. This was a tough project and it looks like you learned a lot. Also look at your hotel class and look at the loops in some of the methods, they look like they repeat a lot, you could do some DRYing up here.

CheezItMan

Notes on your code.

CheezItMan · 2017-09-14T19:14:24Z

lib/block_reservation.rb

+      @cost = cost
+    end
+
+    def block_rate


Shouldn't you simply override the rate method?

Why create the same method by a different name in a subclass?

CheezItMan · 2017-09-14T19:17:36Z

lib/reservation.rb

+
+    def rate
+      nights = @check_out_date - @check_in_date
+      @cost = nights.to_i * Room::RATE


You set the cost to a different value in initialize. Why?

CheezItMan · 2017-09-14T19:22:24Z

lib/room.rb

+  class Room
+    attr_reader :room_number
+
+    RATE = 200


Good use of a constant!

CheezItMan · 2017-09-14T19:29:56Z

lib/hotel.rb

+  class Hotel
+    attr_reader :rooms, :reservations, :found_reservations, :unreserved_rooms, :blocks
+    def initialize
+      @rooms = []


If you're setting @rooms to [] in initialize, why do you have an add_20_rooms method. I would suggest instead making add_20_rooms private and calling it from initialize. I would also suggest renaming it to something less specific as to the implementation (number of rooms). That way you could extend or subclass Hotel and override the method to change the number of rooms.

CheezItMan · 2017-09-14T19:43:20Z

lib/hotel.rb

+
+    # creates a reservation
+    def create_reservation(first_name, last_name, check_in_date, check_out_date, room_number)
+


The Reservation class should be checking for it being created with invalid dates.

CheezItMan · 2017-09-14T19:43:36Z

lib/hotel.rb

+
+
+    def reservations_by_date(date)
+      @reservations.each { |reservation|


Good use of enumerables in this project.

…e_reservation method with the Hotel class & updated the create block method in the Hotel class

hellomarisamorris added 21 commits September 5, 2017 14:04

Lib, Speck, Rake, and Spec Helper files created.

9b0e8a5

Added hotel class & HotelManagement Module. Tests passing for Hotel a…

25b1675

…nd Room classes.

Added tests to reservation and Hotel class. Added reservation numner …

a5bf73e

…to initialize method.

updated reservation class and tests. reservation class now has room_n…

3de1164

…umber instance

Added more tests to Hotel Class

c2c919d

Added rate method to reservation class and tests.

4800909

All tests passin. Updated rooms and reservation classes (got rid of w…

fc4bc05

…hat wasnt needed).

Rate is now a constant. Updated tests accordingly.

472f74d

Wave 2 complete

1d81dc5

wave 2: method to list unreserved rooms for a given range complete. t…

76cbbdf

…est passing

Additional tests for rooms_not_reserved method.

9d61cab

reserve_room_for_date_range method fixed and tests passing. wave 2 co…

d0f04d7

…mplete.

Wave 3: created block and block reservation classes.

6d8c2dc

Wave 3: block class testst passing

c679ceb

Wave 3: block reservation class set up. inheriting from reservation c…

68a6906

…lass. block rate method tests passing

Wave 3: BlockReservation class tests passing

a68ce8c

added to block class. checkin and check out dates.

29bdaf2

create block method complete tests pass.

a7a3f33

.

bf4d70d

updated conditional in rooms_not_reserved method.

8c7ac00

can reserve a room within a block. 99% coverage.

dfd1487

CheezItMan reviewed Sep 14, 2017

View reviewed changes

lib/hotel.rb

def reservations_by_date(date)

@reservations.each { |reservation|

Copy link

CheezItMan Sep 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of enumerables in this project.

hellomarisamorris added 3 commits September 27, 2017 23:38

design-activity completed

d9d2022

Completed design-acivity and updated hotel. Updates: refactored creat…

b8bb268

…e_reservation method with the Hotel class & updated the create block method in the Hotel class

removed unnecessary commented out code

2261275

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Marisa Morris - Carets #23

Marisa Morris - Carets #23

marisamorris commented Sep 11, 2017

CheezItMan commented Sep 14, 2017 •

edited

Loading

CheezItMan left a comment

CheezItMan Sep 14, 2017

CheezItMan Sep 14, 2017

CheezItMan Sep 14, 2017

CheezItMan Sep 14, 2017

CheezItMan Sep 14, 2017

CheezItMan Sep 14, 2017


		# creates a reservation
		def create_reservation(first_name, last_name, check_in_date, check_out_date, room_number)



		def reservations_by_date(date)
		@reservations.each { \|reservation\|

Marisa Morris - Carets #23

Are you sure you want to change the base?

Marisa Morris - Carets #23

Conversation

marisamorris commented Sep 11, 2017

Hotel

Comprehension Questions

CheezItMan commented Sep 14, 2017 • edited Loading

Hotel

What We're Looking For

CheezItMan left a comment

Choose a reason for hiding this comment

CheezItMan Sep 14, 2017

Choose a reason for hiding this comment

CheezItMan Sep 14, 2017

Choose a reason for hiding this comment

CheezItMan Sep 14, 2017

Choose a reason for hiding this comment

CheezItMan Sep 14, 2017

Choose a reason for hiding this comment

CheezItMan Sep 14, 2017

Choose a reason for hiding this comment

CheezItMan Sep 14, 2017

Choose a reason for hiding this comment

CheezItMan commented Sep 14, 2017 •

edited

Loading