-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for new __sklearn_tags__ #205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm; but did not directly test
Was this ever fixed, I am using Cebra v0.4.0 and now receiving this error:
This is after installing the latest Cebra package with the scikit-learn v1.6.0. |
rolling back scikit-learn back to v1.5.2 worked |
Hi @Gunnar-Stunnar , this was merged after the cebra 0.4.0 release. If you install the latest version from git,
the error should disappear even with sklearn > |
Looks like it worked! My logs are now being filed with this error:
|
I recently installed CEBRA and am still gettitng the first error. I rolled back to scikit-learn back to v1.5.2 and now am getting this log error described above |
You would need to pull from git, but a new version is coming soon! |
if i re-install from git, will it change the PyTorch version I currently have installed in my conda environment? Should I just make a new environment to install from git? |
are you referring to this log output? This is just a warning message which is safe to ignore, there is no effect with respect to model fitting. You can configure the Otherwise, as @MMathisLab noted, we will soon also release a new version of CEBRA properly handling this. |
Fix #204
sklearn 1.6.0 was released on Dec 9, 24 and introduced a new mechanism for specifying estimator tags (https://scikit-learn.org/dev/developers/develop.html). This PR adopts CEBRA to comply with this new notation. Older sklearn variants will fall back to the
more_tags()
functions as recommended in this comment.Indepedently, I spotted a bug in the inheritance order in the CEBRA class, which was fixed now, as described here.
Finally, since the code is now version dependent and there might be users rolling older sklearn version, I extended the test suite by one case checking with a legacy sklearn version (version 1.4.2 which is roughly one year old) -- this will hopefully cover the most important cases. The majority of tests are with sklearn latest (1.6.0 as of Dec 16, 24).