Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRF adjustments #106

Merged
merged 3 commits into from
Dec 23, 2024
Merged

CRF adjustments #106

merged 3 commits into from
Dec 23, 2024

Conversation

C-Achard
Copy link
Collaborator

Improves slightly the handling of the CRF optional requirement

  • Move warning when importing package to actually attempting to use crf without it being installed
  • Remove optional dependency in pyproject
  • Update remaining docs to state correct install step (w/o using above optional dep)

@C-Achard C-Achard added the enhancement New feature or request label Dec 23, 2024
@C-Achard C-Achard self-assigned this Dec 23, 2024
@C-Achard C-Achard requested a review from MMathisLab December 23, 2024 09:10
@C-Achard C-Achard added this to the v0.2.2 milestone Dec 23, 2024
@C-Achard C-Achard mentioned this pull request Dec 23, 2024
Merged
1 task
@MMathisLab
Copy link
Member

MMathisLab commented Dec 23, 2024 •
edited
Loading

@C-Achard as mentioned on basecamp, I am working on this issue so it becomes a proper dependency. please wait until it's up on pypi (here is the project: https://github.com/AdaptiveMotorControlLab/pydensecrf); when tests pass again then it's mergeable!

@MMathisLab MMathisLab merged commit a72e931 into main Dec 23, 2024
3 checks passed
@MMathisLab MMathisLab deleted the cy/fix-pydensecrf branch December 23, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MMathisLab MMathisLab MMathisLab approved these changes

Assignees

@C-Achard C-Achard

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@C-Achard @MMathisLab