Skip to content

Commit

Permalink
ci: use lts node versions on CI
Browse files Browse the repository at this point in the history
  • Loading branch information
tachyons committed Sep 21, 2024
1 parent 453ac62 commit 6a7af5d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 20 deletions.
19 changes: 3 additions & 16 deletions .github/workflows/jest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,23 +23,10 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: Setup Node.js
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: "14.18.0"

# Speed up subsequent runs with caching
- name: Cache node modules
uses: actions/cache@v2
env:
cache-name: cache-node-modules
with:
# npm cache files are stored in `~/.npm` on Linux/macOS
path: ~/.npm
key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-build-${{ env.cache-name }}-
${{ runner.os }}-build-
${{ runner.os }}-
node-version: 'lts/*'
cache: 'yarn'

# Install required deps for action
- name: Install Dependencies
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/rubyonrails.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
env:
RAILS_ENV: test
DATABASE_URL: "postgres://rails:password@localhost:5432/rails_test"

steps:
- name: Checkout code
uses: actions/checkout@v4
Expand All @@ -31,9 +31,9 @@ jobs:
uses: ruby/setup-ruby@v1 # v1.115.3
with:
bundler-cache: true
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: '16'
node-version: 'lts/*'
cache: 'yarn'
- name: Install reviewdog
uses: reviewdog/action-setup@v1
Expand All @@ -54,7 +54,7 @@ jobs:
openssl rsa -in config/private.pem -outform PEM -pubout -out config/public.pem
- name: Run tests
run: bundle exec rspec

- name: Keep screenshots from failed system tests
uses: actions/upload-artifact@v4
if: failure()
Expand Down

0 comments on commit 6a7af5d

Please sign in to comment.