Add CLI command to list and delete custom actions #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
danielgrittner
requested changes
Oct 3, 2024
admyral/db/admyral_store.py
Outdated
Comment on lines
238
to
280
| delete(PythonActionSchema).where( | ||
| PythonActionSchema.action_type == action_type | ||
| ) |
There was a problem hiding this comment.
You need to consider the user_id too. Can you merge the newest changes into your branch.
leon-schmid
force-pushed
the
ADM-312/CLI-command-to-list-and-delete-custom-actions
branch
from
47e4081 to
3d4de07
Compare
danielgrittner
requested changes
Oct 3, 2024
admyral/cli/action.py
Outdated
|
|
||
| @action.command( | ||
| "list", | ||
| help="List all pushed actions", |
There was a problem hiding this comment.
Suggested change
| help="List all pushed actions", | |
| help="List all custom actions", |
| authenticated_user: AuthenticatedUser = Depends(authenticate), | ||
| ) -> list[ActionMetadata]: | ||
| """ | ||
| List all stored Python actions. |
There was a problem hiding this comment.
Suggested change
| List all stored Python actions. | |
| List all stored custom Python actions. |
| List all stored Python actions. | ||
|
|
||
| Returns: | ||
| A list of Python action objects. |
There was a problem hiding this comment.
Suggested change
| A list of Python action objects. | |
| A list of custom Python action objects. |
| action_type: str, authenticated_user: AuthenticatedUser = Depends(authenticate) | ||
| ) -> None: | ||
| """ | ||
| Delete a Python action by its action type. |
There was a problem hiding this comment.
Suggested change
| Delete a Python action by its action type. | |
| Delete a custom Python action by its action type. |
| Delete a Python action by its action type. | ||
|
|
||
| Args: | ||
| action_type: The action type. |
There was a problem hiding this comment.
Suggested change
| action_type: The action type. | |
| action_type: The function name of the custom action. |
leon-schmid
force-pushed
the
ADM-312/CLI-command-to-list-and-delete-custom-actions
branch
from
d341b99 to
0d0e894
Compare
danielgrittner
approved these changes
Oct 7, 2024
leon-schmid
deleted the
ADM-312/CLI-command-to-list-and-delete-custom-actions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new CLI action commands:
listto list all pushed actionsdeleteto delete a specified action