Remove React sample (and its build directory) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove React sample, per discussion with AmitG. Per discussion with Cathy, and further testing, we think removing this build folder (created by the React sample) will alleviate the checkin error, previously encountered.
…s/bbb/removeReact
w3dong23
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
To avoid hitting error of check internal links for pr-check, we might consider removing
- name: Check internal links
uses: borales/actions-yarn@v3
with:
cmd: test:links
from the workflow file for now. It will always not able to locate the "test:links" without package.json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove React sample (and its build directory).
Cathy thinks that the .json in the build directory, is what was triggering yesterday's warnings.