Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump alpine version to v3.13 (latest) #513

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

Gabitchov
Copy link
Contributor

I bump the version of alpine to the latest stable, 3.13: https://www.alpinelinux.org/releases/

@karianna karianna added this to the February 2021 milestone Feb 19, 2021
@karianna karianna requested a review from dinogun February 19, 2021 18:38
@grzesuav
Copy link
Contributor

hi @Gabitchov , all dockerfiles are generated from scripts, so the place which needs update is here - https://github.com/AdoptOpenJDK/openjdk-docker/blob/master/dockerfile_functions.sh#L156

@Gabitchov Gabitchov force-pushed the bump-alpine-to-v3-13 branch 3 times, most recently from 2280082 to 2aa73ae Compare February 20, 2021 15:54
@Gabitchov
Copy link
Contributor Author

Gabitchov commented Feb 20, 2021

hi @Gabitchov , all dockerfiles are generated from scripts, so the place which needs update is here - https://github.com/AdoptOpenJDK/openjdk-docker/blob/master/dockerfile_functions.sh#L156

@grzesuav Thanks for your feedback.
Do I need to generate something or this is enough to update all image? Let me know.

@grzesuav
Copy link
Contributor

Actually images in this repo aren't use in builds - they are for users only. At each run images are regenerated. Dockerfiles in repo are from time to time updated by @dinogun . @dinogun can you confirm ?

@Gabitchov Gabitchov force-pushed the bump-alpine-to-v3-13 branch from 2aa73ae to d2a0129 Compare February 21, 2021 17:19
Copy link
Collaborator

@dinogun dinogun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dinogun dinogun merged commit 50ad009 into AdoptOpenJDK:master Feb 23, 2021
@consult-kk
Copy link

Hi,
Does this PR bump the Alpine version to 3.13 ? I still see the individual Dockerfiles referencing Alpine 3.12.
If the JRE images ( JRE 13.x ) has been updated to use Alpine 3.13 . How can I reference the updated image .
Thanks,
KK

@Gabitchov
Copy link
Contributor Author

Hi,
Does this PR bump the Alpine version to 3.13 ? I still see the individual Dockerfiles referencing Alpine 3.12.
If the JRE images ( JRE 13.x ) has been updated to use Alpine 3.13 . How can I reference the updated image .
Thanks,
KK

Hello,

What I understood, there is one build by day on change. The one for this PR is on going: https://ci.adoptopenjdk.net/job/openjdk_build_docker_multiarch/231/

I am also pending for an updated image but for the openjdk11

Wait and see...

@consult-kk
Copy link

@Gabitchov - No joy.. I still see alpine 3.12 in all the docker.xxx files
is there a time line on when these will be updated ?

@consult-kk
Copy link

Any updates on this. Every version still shows up as using alpine 3.12 . Container Security scanners tools are blocking the older versions due to unresolved CVEs.

@aahlenst
Copy link
Contributor

@consult-kk We reverted back to Alpine 3.12 because of #520. Alpine 3.12 is still supported (= receives security fixes), so the claims of the security scanners sounds dubious.

@consult-kk
Copy link

@consult-kk We reverted back to Alpine 3.12 because of #520. Alpine 3.12 is still supported (= receives security fixes), so the claims of the security scanners sounds dubious.

I will put my trust on an image scanner rather than just claiming it to be "dubious" with out any data backing the claim.
Please see below.
image

@aahlenst
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants