Eclipse and gams studio #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank-agarwal-96
requested changes
Jan 31, 2022
|
Need to rework that to use the new desktop.
From: Mayank Agrawal ***@***.***>
Reply-To: AdvancedResearchComputing/OnDemandApps ***@***.***>
Date: Monday, January 31, 2022 at 11:05 AM
To: AdvancedResearchComputing/OnDemandApps ***@***.***>
Cc: Bob Settlage ***@***.***>, Review requested ***@***.***>
Subject: Re: [AdvancedResearchComputing/OnDemandApps] Eclipse and gams studio (PR #12)
@mayank-agarwal-96 requested changes on this pull request.
________________________________
In bc_vt_Eclipse/Dockerfiles/Dockerfile_cpp<#12 (comment)>:
@@ -0,0 +1,13 @@
+FROM accetto/ubuntu-vnc-xfce-firefox-g3:latest
+
+# For JAVA
+#COPY eclipse-java-2021-03-R-linux-gtk-x86_64.tar.gz
+
+# For C++
+COPY eclipse-cpp-2021-03-R-linux-gtk-x86_64.tar.gz /home/headless
I think we need to download this using wget or a similar utility.
________________________________
In bc_vt_Eclipse/Dockerfiles/Dockerfile_cpp<#12 (comment)>:
@@ -0,0 +1,13 @@
+FROM accetto/ubuntu-vnc-xfce-firefox-g3:latest
+
+# For JAVA
+#COPY eclipse-java-2021-03-R-linux-gtk-x86_64.tar.gz
+
+# For C++
+COPY eclipse-cpp-2021-03-R-linux-gtk-x86_64.tar.gz /home/headless
+
+RUN echo -e "headless\n" | sudo -S apt-get update \
Are these echo -e "headless\n" statements added for debugging purposes? I think those should be removed before final merge
________________________________
In bc_vt_Eclipse/Dockerfiles/Dockerfile_cpp<#12 (comment)>:
@@ -0,0 +1,13 @@
+FROM accetto/ubuntu-vnc-xfce-firefox-g3:latest
+
+# For JAVA
+#COPY eclipse-java-2021-03-R-linux-gtk-x86_64.tar.gz
+
+# For C++
+COPY eclipse-cpp-2021-03-R-linux-gtk-x86_64.tar.gz /home/headless
+
+RUN echo -e "headless\n" | sudo -S apt-get update \
+ && echo -e "headless\n" | sudo -S apt install -y build-essential libpci-dev libwebkit2gtk-4.0-dev
+
+RUN cd /home/headless/ \
+ && tar -zxvf eclipse-cpp-2021-03-R-linux-gtk-x86_64.tar.gz
Newlines at the end is missing here and multiple other places
________________________________
In bc_vt_Eclipse/Dockerfiles/Dockerfile_java<#12 (comment)>:
+# For C++
+#COPY eclipse-cpp-2021-03-R-linux-gtk-x86_64.tar.gz /home/headless
+
This block can be removed.
—
Reply to this email directly, view it on GitHub<#12 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AD6PNQGHCWMOGBCJY3YWZHLUY2XMBANCNFSM5NFLJKTA>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed Eclipse