fix(fast-usdc): .exit() all internal temporary seats #10939
Conversation
Deploying agoric-sdk with
|
| Latest commit: |
0b961a1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://43632cff.agoric-sdk.pages.dev |
| Branch Preview URL: | https://dc-fu-res-misc.agoric-sdk.pages.dev |
| }; | ||
|
|
||
| trace('script finishing'); | ||
| pruneFastUsdcStorage; |
There was a problem hiding this comment.
We don't have an extension for scripts that run in CoreEval. .core.js is for scripts that are built by a .build.js into a script that runs.
So I think this filename is fine for now, but it shouldn't be part of src because it's not a package export. How about in scripts?
| @@ -223,7 +223,8 @@ export const prepareAdvancerKit = ( | |||
| onFulfilled(result, ctx) { | |||
| const { poolAccount, intermediateRecipient, settlementAddress } = | |||
| this.state; | |||
| const { destination, advanceAmount, tmpSeat: _, ...detail } = ctx; | |||
| const { destination, advanceAmount, tmpSeat, ...detail } = ctx; | |||
| tmpSeat.exit(); | |||
dckc
force-pushed
the
dc-fu-res-misc
branch
5 times, most recently
from
c757f81 to
d244bd0
Compare
dckc
changed the title
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
discovered by running many iterations of the contract and looking at kernel statistics (controller.getStats())
|
Even after 3 tries, I'm blocked by a ci flake |
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
closes #10890
refs:
Description
mainly:
Also, to exercise pruning vstorage:
To speed up testing and match it with expected deployment:
Plus a misc type refinement:
Security / Scaling Considerations
Reducing leaks improves scalability which improves availability.
Documentation Considerations
I don't think so.
Testing Considerations
Tests are in #10931 ; they're somewhat rough and not included in this PR.
Upgrade Considerations
Some undiagnosed heap growth remains. A fix for that might go out in a future upgrade.