Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up minor issues found during benchmark writeup #8764

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Clean up minor issues found during benchmark writeup #8764

merged 1 commit into from
Jan 22, 2024

Conversation

FUDCo
Copy link
Contributor

@FUDCo FUDCo commented Jan 18, 2024

-- Change the CPU profile sample interval to be more fine grained
-- Fix a minor bug in legibilizeValue found while updating slogulator

In service of #8647 but not it yet.

@FUDCo FUDCo added the SwingSet package: SwingSet label Jan 18, 2024
@FUDCo FUDCo requested a review from warner January 18, 2024 01:34
@FUDCo FUDCo self-assigned this Jan 18, 2024
@FUDCo FUDCo mentioned this pull request Jan 18, 2024
Merged
warner
warner approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, I'm guessing the smaller sampling interval is a serious perf hit, but when you want the data, that's what you gotta do.

@FUDCo
feat: cleanup minor issues found during benchmark writeup
100922b 
-- Change the CPU profile sample interval to be more fine grained
-- Fix a minor bug in legibilizeValue found while updating slogulator

In service of #8647 but not it
@FUDCo FUDCo force-pushed the 8647-benchmark-kernel-cleanup branch from fee0646 to 100922b Compare January 22, 2024 21:39
@FUDCo
Copy link
Contributor Author

FUDCo commented Jan 22, 2024

sounds good, I'm guessing the smaller sampling interval is a serious perf hit, but when you want the data, that's what you gotta do

Exactly so.

@FUDCo FUDCo added the automerge:rebase Automatically rebase updates, then merge label Jan 22, 2024
@mergify mergify bot merged commit 6b07a7b into master Jan 22, 2024
74 checks passed
@mergify mergify bot deleted the 8647-benchmark-kernel-cleanup branch January 22, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warner warner warner approved these changes

Assignees

@FUDCo FUDCo

Labels
automerge:rebase Automatically rebase updates, then merge SwingSet package: SwingSet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FUDCo @warner