refactor(xsnap): Cleanup build.js #9674
Open
+172
−179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Trim child-process stdout trailing whitespace by default. * Parse `git submodule status "$path"` output as a single line into a single record.
…tform, force, io)` ...for intra- and inter-file consistency
...avoiding a boolean trap
gibson042
force-pushed
the
gibson-2024-07-xsnap-build-cleanup
branch
from
308f456 to
c981c22
Compare
Deploying agoric-sdk with
|
| Latest commit: |
c981c22
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f747883c.agoric-sdk.pages.dev |
| Branch Preview URL: | https://gibson-2024-07-xsnap-build-c.agoric-sdk.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #9614
Ref #9618
Description
Simplifies and documents functions. See individual commits for details.
Security Considerations
None.
Scaling Considerations
n/a
Documentation Considerations
Includes JSDoc improvements.
Testing Considerations
None.
Upgrade Considerations
n/a