Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(webflux): remove unused IDs query aggregate functionality #1157

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

Ahoo-Wang
Copy link
Owner

  • Remove IdsQueryAggregateHandlerFunction and related classes
  • Delete corresponding test cases
  • Update WebFluxAutoConfiguration to remove bean definition
  • Remove IdsQueryAggregateRouteSpecFactory from service loader configuration

- Remove IdsQueryAggregateHandlerFunction and related classes
- Delete corresponding test cases
- Update WebFluxAutoConfiguration to remove bean definition
- Remove IdsQueryAggregateRouteSpecFactory from service loader configuration
Copy link
Contributor

Test Results

1 126 tests   - 1   1 109 ✅  - 1   10m 11s ⏱️ +33s
  313 suites  - 1      17 💤 ±0 
  313 files    - 1       0 ❌ ±0 

Results for commit 57191f4. ± Comparison against base commit 586e52c.

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.95%. Comparing base (586e52c) to head (57191f4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1157      +/-   ##
============================================
- Coverage     89.01%   88.95%   -0.06%     
+ Complexity     3184     3166      -18     
============================================
  Files           653      651       -2     
  Lines         11404    11357      -47     
  Branches        778      778              
============================================
- Hits          10151    10103      -48     
- Misses          761      762       +1     
  Partials        492      492              
Flag Coverage Δ
unittests 88.95% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ahoo-Wang Ahoo-Wang merged commit e989a0d into main Feb 10, 2025
36 checks passed
@Ahoo-Wang Ahoo-Wang deleted the IdsQueryAggregateRouteSpec branch February 10, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant