Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add owner id support for commands #1175

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

Ahoo-Wang
Copy link
Owner

  • Add OwnerId annotation and related property getter
  • Update CommandFactory to handle owner id
  • Extend CommandMetadata with ownerIdGetter
  • Update CommandMetadataParser to parse owner id
  • Add unit tests for owner id functionality

- Add OwnerId annotation and related property getter
- Update CommandFactory to handle owner id
- Extend CommandMetadata with ownerIdGetter
- Update CommandMetadataParser to parse owner id
- Add unit tests for owner id functionality
@Ahoo-Wang Ahoo-Wang added the enhancement New feature or request label Feb 13, 2025
Copy link
Contributor

Test Results

1 144 tests  +1   1 127 ✅ +1   9m 41s ⏱️ -1s
  316 suites ±0      17 💤 ±0 
  316 files   ±0       0 ❌ ±0 

Results for commit db00ed5. ± Comparison against base commit b1868ce.

Copy link
Contributor

Test Results

1 144 tests  +1   1 127 ✅ +1   9m 58s ⏱️ +18s
  316 suites ±0      17 💤 ±0 
  316 files   ±0       0 ❌ ±0 

Results for commit db00ed5. ± Comparison against base commit b1868ce.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.03%. Comparing base (b1868ce) to head (db00ed5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../main/kotlin/me/ahoo/wow/command/CommandFactory.kt 50.00% 0 Missing and 1 partial ⚠️
...oo/wow/command/annotation/CommandMetadataParser.kt 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1175      +/-   ##
============================================
- Coverage     89.04%   89.03%   -0.02%     
- Complexity     3209     3212       +3     
============================================
  Files           656      656              
  Lines         11530    11537       +7     
  Branches        783      785       +2     
============================================
+ Hits          10267    10272       +5     
  Misses          780      780              
- Partials        483      485       +2     
Flag Coverage Δ
unittests 89.03% <77.77%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ahoo-Wang Ahoo-Wang merged commit 90ca453 into main Feb 13, 2025
50 checks passed
@Ahoo-Wang Ahoo-Wang deleted the owner-id-support-for-commands branch February 13, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant