Ah/chore/update #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds versioning support to the s5cmd. Added --all-versions flag to ls, rm, du and select subcommands to apply operation on(/over) all versions of the objects. Added --version-id flag to cat, cp/mv, rm, du and select subcommands to apply operation on(/over) a specific versions of the object. Added bucket-version command to configure bucket versioning. Bucket name alone returns the bucket versioning status of the bucket. Bucket versioning can be configured with set flag which only accepts. Added --raw flag to cat and select subcommands. It disables the wildcard operations. Note: Google Cloud Storage uses a different approach for versioning. So with current implementation, s5cmd cannot use or retrieve generation numbers . However, bucket-version command and du command with all-versions flag works as expected since they do not use version ids. Fixes: peak#218 Fixes: peak#386 Fixes: peak#539
Co-authored-by: Onur Sönmez <[email protected]>
This PR updates the help messages for the commands that takes arguments containing wildcards. Since the expansion of wildcards are evaluated by the shell and not by the s5cmd beforehand, there is no way for app to prevent the expansion. We urge users to consider escaping from globbing by wrapping the related argument to quotes. Obviously, the escaping method can be different for every shell implementation. Fixes peak#555
The flag now shows the date, ETag etc. of the objects. Updates peak#596 .
Co-authored-by: İbrahim Güngör <[email protected]>
Co-authored-by: Selman Kayrancioglu <[email protected]>
This PR adds a new io.WriterAt adapter for non-seekable writers. It uses an internal linked list to order the incoming chunks. The implementation is independent from the download manager of aws-sdk-go, and because of that currently it can not bound the memory usage. In order to limit the memory usage, we would have had to write a custom manager other than the aws-sdk-go's implementation, which seemed unfeasible. The new implementation is about %25 percent faster than the older implementation for a 9.4 GB file with partSize=50MB and concurrency=20 parameters, with significantly higher memory usage, on average it uses 0.9 GB of memory and at most 2.1 GB is observed. Obviously, the memory usage and performance is dependent on the partSize-concurrency configuration and the link. Resolves peak#245 Co-authored-by: İbrahim Güngör <[email protected]>
Co-authored-by: İbrahim Güngör <[email protected]>
Resolves peak#51 Enables usage of cp command with show-progress flag to show progress bar for a copy task. Example progress bar: 78.00% ━━━━━━━━━━━━━━━━━━━━──────── 780 MB / 1.00 GB (189.37 MB/s) 5.9s (28/29)
Co-authored-by: Selman Kayrancioglu <[email protected]> Co-authored-by: İbrahim Güngör <[email protected]>
Co-authored-by: Selman Kayrancioglu <[email protected]> Co-authored-by: İbrahim Güngör <[email protected]>
GCS now supports ListObjectsV2 XML API according to their changelog. cloud.google.com/storage/docs/release-notes#July_12_2021 I choose to believe the doc because I haven't tested it :) Fixes peak#513
Manual control of dependency is fine but with a growing no. of distributed upstream dependencies, it is hard to manage. So, for that automation should be there to update dependencies. Further, CI Pipeline is there to test those changes. The current build is having many old dependencies due to that many vulnerabilities were found. i.e. why workflow automation will help here. Further, this will not update the dependencies automatically, instead, a PR will be opened with changes that can be reviewed and tested with CI. Signed-off-by: Pratik Raj [email protected]
Resolves peak#564 Changes are made: - Added `exit-on-error` flag. Its value is `false` by default. - Added `shouldStopSync` function. It determines whether a sync process should be stopped or not. It does not ignore the errors `AccessDenied` and `NoSuchBucket` regardless of the value of `exit-on-error` flag. - `sync` command stops if an error is received when listing objects from source or destination when the `exit-on-error` flag is `true`. But it always ignores the `ErrNoObjectFound` error. --------- Co-authored-by: İlkin Balkanay <[email protected]> Co-authored-by: Onur Sönmez <[email protected]>
Resolves peak#498 Changes are made: - `cp` command checks file mode bits before trying to copy. If the file is a special file, `cp` do not copy that file. It neither returns an error nor prints a message. The copy process continues as usual. - As `sync` uses `cp` in the background, it behaves like `cp`, so it does not sync special files.
…ak#636) Resolves peak#541 While running the sync command it starts to generate cp commands in the generateCommand function and writes it to a pipe where it is read by the Run function of the Run command. In the Run function, there is a line `fields, err := shellquote.Split(line)` to split the generated cp command into its fields. For a command ``` s5cmd sync --cache-control ‘public, max-age=31536000, immutable’ /Users/ataberk/desktop/test s3://s5cmd-test2 ``` We would have expected the generateCommand function to write into the pipe a command ``` cp --cache-control='public, max-age=31536000, immutable' --raw='true' \"/Users/ataberk/desktop/test/hello.txt\" \"s3://s5cmd-test2/test/hello.txt\" ``` But instead, it writes the command ``` cp --cache-control=public, max-age=31536000, immutable --raw=true \"/Users/ataberk/desktop/test/hello.txt\" \"s3://s5cmd-test2/test/hello.txt\" ```  This causes the `shellquote.Split(line)` to split fields incorrectly. This causes `flagset.Parse(fields)` to populate flagset incorrectly and as a result we end up with an error.  The main problem occurs in the generateCommand function while appending flags without quotes. If we add quotes around the flagValue while generating a command. The `shellquote.Split(line)` acts as intended and successfully sync with the given cache-control metadata in S3   Co-authored-by: Ataberk Gürel <[email protected]>
Co-authored-by: İbrahim Güngör <[email protected]>
Co-authored-by: İbrahim Güngör <[email protected]>
Co-authored-by: İbrahim Güngör <[email protected]>
…r `presign` command (peak#644)
peak#657 mentioned that `acl` flag was broken in `v2.2.1`. After looking at the issue, it was discovered that not only the `acl` flag was broken, there are couple of more flags that were being omitted during the mentioned commands, which all of them caused by this faulty [PR](peak#621). Resolves peak#657.
Go report shows report for the latest version associated with the relevant module (name), hence the major version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.