Fix compatibility with airwave gen1 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like 'date_time' dict entry is not populated for v1 of the airwave, which causes _get_service_characteristics to throw an error. I'm not sure why this is the case or what the expectation is, but since the date_time entry is getting popped anyways, I figured that adding a condition guard is the quickest/easiest fix. After this change I can import the sensor into home assistant, whereas prior to change adding the integration would fail with `[homeassistant.components.airthings_ble.config_flow] Unknown error occurred from CC:78:AB:15:75:02: 'date_time'`
|
Thanks @igorbernstein. This worked for me to fix the issue I reported over at home-assistant/core#81498. |
|
@vincegio would love to see this merge into the current main build. |
|
Thanks! I'll get it updated and creating a PR in core to bump the package as well. |
vincegio
pushed a commit
that referenced
this pull request
Nov 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like 'date_time' dict entry is not populated for v1 of the airwave, which causes _get_service_characteristics to throw an error. I'm not sure why this is the case or what the expectation is, but since the date_time entry is getting popped anyways, I figured that adding a condition guard is the quickest/easiest fix.
After this change I can import the sensor into home assistant, whereas prior to change adding the integration would fail with
[homeassistant.components.airthings_ble.config_flow] Unknown error occurred from CC:78:AB:15:75:02: 'date_time'