Edit for brevity #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry, I couldn't myself. It's way too wordy IMO. My experience with interacting with people over email and other electronic written media is that shorter is better! :)
mpagels
reviewed
Feb 5, 2022
There was a problem hiding this comment.
Hi @mangstadt, I like your changes very much. But I also like the original message very much. Maybe instead of changing the original message completely, it would be a good idea to add your message as a "shorter" version? That way, people can decide which version they want to use? Just an idea.
|
I like this a lot, commenting to save |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I couldn't myself. It's way too wordy IMO. My experience with interacting with people over email and other electronic written media is that shorter is better! Anyway, have a good day! :)