Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README and config #11

Merged
merged 3 commits into from
May 20, 2024
Merged

Update README and config #11

merged 3 commits into from
May 20, 2024

Conversation

sjspielman
Copy link
Member

@sjspielman sjspielman commented May 20, 2024

Closes #10
Does most of #3 (will check off after merge)

This PR updates the README to be forward-facing, and fills in all config values except the docker image.

@sjspielman sjspielman requested a review from jashapiro May 20, 2024 19:50
README.md Outdated

Please find the workshop website at: https://alexslemonade.github.io/2024-june-training/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not active yet, so I might hold off on updating the readme?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make sure the issue stays open. I'd like to get a draft schedule in before turning on pages I think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make sure the issue stays open. I'd like to get a draft schedule in before turning on pages I think?

Makes sense to me

@sjspielman sjspielman requested a review from jashapiro May 20, 2024 20:15
Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👔

@sjspielman sjspielman merged commit 9c052bf into main May 20, 2024
1 check passed
@sjspielman sjspielman deleted the sjspielman/readme-config branch May 20, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update README to be user-facing (remove instructions)
2 participants